Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushing init logic into Make. Focusing on 'demo', 'local', and (not q… #132

Merged
merged 20 commits into from
Mar 16, 2021
Merged

Pushing init logic into Make. Focusing on 'demo', 'local', and (not q… #132

merged 20 commits into from
Mar 16, 2021

Conversation

dannylamb
Copy link
Member

…uite yet but soon) 'remote'

This was referenced Jan 6, 2021
Merged
Merged
Merged
@dannylamb
Copy link
Member Author

Ok, so I've got drafts up for everything and it's functionally 👍. I'm going to work through coding standards etc.. and undraft them and get some testing instructions in here.

@dannylamb dannylamb changed the title Pusing init logic into Make. Focusing on 'demo', 'local', and (not q… Pushing init logic into Make. Focusing on 'demo', 'local', and (not q… Jan 19, 2021
@dannylamb dannylamb marked this pull request as ready for review February 22, 2021 15:02
@dannylamb
Copy link
Member Author

This all works fine if you use secrets. Unfortunately, I just tested from a fresh clone and bumped into some troubles because by default we're set not to use secrets. It's looking like it's just some more spots to touch up in buildkit with the new defaults. I'll let you know what I find, but for now, if you use secrets everything is 👌

@dannylamb
Copy link
Member Author

I've updated Islandora-Devops/isle-buildkit#95 and have bumped the commit hash to point to it. This works with and without secrets now.

This was referenced Mar 11, 2021
Merged
Merged
@dannylamb
Copy link
Member Author

This has been updated along with isle-buildkit. You can try this out by pulling in these changes and running make demo to get a sandbox and make local to get a barebones install.

nigelgbanks
nigelgbanks approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me!

@nigelgbanks nigelgbanks merged commit 2e6ee76 into development Mar 16, 2021
@dannylamb dannylamb deleted the post-sprint-4 branch March 16, 2021 18:48
ruebot added a commit to yorkulibraries/Alpaca that referenced this pull request May 3, 2021
@ruebot
Remove calls to Gemini.
8e2d647 
- Best GitHub issue would be: Islandora-Devops/isle-dc#132
@ruebot ruebot mentioned this pull request May 3, 2021
Merged
ruebot added a commit to yorkulibraries/Alpaca that referenced this pull request May 3, 2021
@ruebot
Remove calls to Gemini and file.stream.
92df03f 
- Best GitHub issue would be: Islandora-Devops/isle-dc#132
birkland added a commit to birkland/isle-dc that referenced this pull request Jun 8, 2021
@birkland
Merge pull request Islandora-Devops#132 from jhu-idc/issue-131
5212100 
 import config/sync when starting with no pre-existing state
This was referenced Jun 30, 2021
Merged
Merged
dannylamb pushed a commit to Islandora/Alpaca that referenced this pull request Jul 2, 2021
@ruebot
Remove calls to Gemini and file.stream. (#78)
31c9e74 
- Best GitHub issue would be: Islandora-Devops/isle-dc#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelgbanks nigelgbanks nigelgbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannylamb @noahwsmith @nigelgbanks